Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading Firely packages to v5. #4760

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

tarunmathew12
Copy link

@tarunmathew12 tarunmathew12 commented Dec 26, 2024

Description

The change upgrades the Firely package version to v5. It also includes fixes caused by the version upgrade that has a number of breaking changes as well as test failures.

Related issues

Addresses [issue #135365].
User Story 135365: Investigate & Fix Unit, Integration, & E2E Test Failures for Firely V5 Upgrade

Testing

Tested by the PR pipeline.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@tarunmathew12 tarunmathew12 added Dependencies Pull requests that update a dependency file Open source This change is only relevant to the OSS code or release. labels Dec 26, 2024
@tarunmathew12 tarunmathew12 added this to the backlog milestone Dec 26, 2024
@tarunmathew12 tarunmathew12 requested a review from a team as a code owner December 26, 2024 23:48
Comment on lines +1267 to +1271
foreach (var system in systems)
{
var subsettedTag = new Coding(system, "SUBSETTED");
patients[i].Meta.Tag.Add(subsettedTag);
}

Check notice

Code scanning / CodeQL

Missed opportunity to use Select Note test

This foreach loop immediately
maps its iteration variable to another variable
- consider mapping the sequence explicitly using '.Select(...)'.
@tarunmathew12
Copy link
Author

tarunmathew12 commented Jan 14, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file Open source This change is only relevant to the OSS code or release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants